From: Florian Müllner Date: Mon, 13 Mar 2017 19:32:06 +0000 (+0100) Subject: messageTray: Ignore showBanners policy for critical notifications X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~442 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=60a2794c8b29fde688daad1df085e08821aa6038;p=gnome-shell.git messageTray: Ignore showBanners policy for critical notifications The critical hint is meant to be used for notifications that must not be missed - running out of battery being the prime example - so it makes sense to ignore the policy in that case and make sure to always show them to the user. This is consistent with blocking normal notifications while showing a fullscreen window, but letting critical ones through. https://bugzilla.gnome.org/show_bug.cgi?id=779974 --- diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js index 0c7a5e4cd..63e6ca182 100644 --- a/js/ui/messageTray.js +++ b/js/ui/messageTray.js @@ -803,7 +803,7 @@ const Source = new Lang.Class({ notification.acknowledged = false; this.pushNotification(notification); - if (this.policy.showBanners) { + if (this.policy.showBanners || notification.urgency == Urgency.CRITICAL) { this.emit('notify', notification); } else { notification.playSound();